use VersionedSlate for the owner_rpc api #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All fine, will merge on top of my other PR and then change the new set of 'secure' functions to use versioned slate as well. |
yeastplume
approved these changes
Aug 6, 2019
garyyu
pushed a commit
to garyyu/grin-wallet
that referenced
this pull request
Sep 5, 2019
garyyu
added a commit
to gottstech/grin-wallet
that referenced
this pull request
Sep 6, 2019
* Update grin crates to v2.0.4 * rustfmt * use VersionedSlate for the owner_rpc api (mimblewimble#202) * rustfmt * rework kernel features support to handle fee and lock_height on features variants * translate to/from TransactionV2 correctly in owner api and foreign api * rustfmt * revert CbData changes mining node calls build_coinbase and this needs to be consistent with grin node * cleanup imports * fixup controller tests * rustfmt * fix the building
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
antiochp
added a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #201
Takes the same approach as the foreign_rpc api where we use
VersionedSlateon the rpc side of things, converting toSlateinternally.These both serialize/deserialize in an identical fashion currently so this does not affect anything.
But once we start modifying
Slateitself (via the containedTransaction) we should be decoupled from these changes.