Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owner API should leverage VersionedSlate and not Slate directly #201

Closed
antiochp opened this issue Aug 1, 2019 · 1 comment · Fixed by #202
Closed

Owner API should leverage VersionedSlate and not Slate directly #201

antiochp opened this issue Aug 1, 2019 · 1 comment · Fixed by #202

Comments

@antiochp
Copy link
Member

antiochp commented Aug 1, 2019

Currently the Owner API uses Slate directly. This is too closely coupled to the internals of grin core. We should break this coupling and leverage VersionedSlate.

Are there any reasons not to do this or why this would cause problems?

@yeastplume
Copy link
Member

I don't know of a reason to not do this, am happy enough to make the change and test.

Can we hold off on this and #129 for a couple of days? The changes within #200 are a bit more pervasive than I thought originally, and I'd just like to get them in first before dealing with (and particularly testing) slate changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants