Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agenda: Development, May 28 2019 #137

Closed
1 of 6 tasks
lehnberg opened this issue May 19, 2019 · 7 comments
Closed
1 of 6 tasks

Agenda: Development, May 28 2019 #137

lehnberg opened this issue May 19, 2019 · 7 comments
Labels
development Anything related to development meetings Anything related to meetings

Comments

@lehnberg
Copy link
Collaborator

lehnberg commented May 19, 2019

Solicit suggestions for agenda items for the Development meeting to be held on Tuesday May 28 @ 15:00 UTC in Grin/Dev Gitter. Please comment to provide topics or suggestions.

Proposed agenda

  1. Igno's Retrospective
  2. Agenda review
  3. Action point follow ups from previous meetings
  4. Security review status
  5. Integration tests
  6. Grin v1.1.0
  7. Grin v1.1.x
  8. Grin v2.0.0
    1. What will change?
    2. Will slates be invalidated after HF?
    3. Get rid of JSON slates?
  9. Guidelines for how/when we communicate upcoming release and HF changes to the community
  10. Other questions
@lehnberg lehnberg added meetings Anything related to meetings development Anything related to development labels May 19, 2019
@yeastplume
Copy link
Member

as part of 2.0.0 discussion I think we collectively need to detail exactly what will change for the Hard fork. for instance, as part of: mimblewimble/grin-wallet#105, we need to know whether all slates will be invalidated after the HF.

@yeastplume
Copy link
Member

Also would like to have a discussion on setting more explicit guidelines for how/when we communicate upcoming release and HF changes to the community, based on recent gitter discussions.

@mcdallas
Copy link

We should discuss if we want to get rid of json slates altogether in v2.0.0 in favor of a more compact encoding as @DavidBurkett suggested

@hashmap
Copy link
Contributor

hashmap commented May 27, 2019

All integration tests are in grin-wallet now, it felt very insecure when a change in node api didn't fail tests, later on I realized that there were no tests for that anymore. Perhaps we need to move back at least some of them (or add as a submodule)

@0xmichalis
Copy link
Contributor

Agreed with @hashmap, better to duplicate these tests across the two repos and start splitting out any wallet specific logic from the mimblewimble/grin tests, than keeping them only in grin-wallet.

@lehnberg
Copy link
Collaborator Author

Agenda proposal updated based on discussion

@jaspervdm
Copy link
Contributor

Regarding item 8: we should also think about a timeline, something like: x weeks before the hard fork we need to have everything ready and tested, which means y weeks before we need to test the hard fork on floonet, which means all changes need to be specified and finalized z weeks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Anything related to development meetings Anything related to meetings
Projects
None yet
Development

No branches or pull requests

6 participants