Skip to content

Latest commit

 

History

History
186 lines (170 loc) · 11.5 KB

20210112-meeting-development.md

File metadata and controls

186 lines (170 loc) · 11.5 KB

Meeting Notes: Development, Jan 12 2021

Development meeting held @ 3PM UTC in grincoin#dev channel on Keybase. Meeting lasted ~ 60 min.

Notes are truncated, and conversations sorted based on topic and not always chronological. Quotes are edited for brevity and clarity, and not always exact.

Community attendance:

  • jaspervdm
  • joltz
  • lehnberg
  • paouky
  • phyro
  • quentinlesceller
  • tromp
  • yeastplume

(apologies if I missed someone - submit a PR or contact @lehnberg to add)

Agenda points & Actions

1. Retrospective

  • yeastplume: The update is easy enough... After much sweat and hard work we have our 5.x release out! I hope everyone is taking some well-deserved relaxation time.
    • 🚀: lehnberg, quentinlesceller, joltz, jaspervdm
  • yeastplume: Some might say that grin is now 'really' released.:d
  • lehnberg: Call outs to a last minute fix that was discovered after last week's meeting and had to go into a 5.0.1 for the node.
  • jaspervdm: Yeah, and a new version for the wallet has to be released as well due to lockfile issues. But other than that I'd say it went mostly smooth.
  • quentinlesceller: Yeah and I think we will shortly need another release for this Lymia/enumset#17. But not urgent. ^^
  • jaspervdm: Yep, going to look into that one as I do not understand why its suddenly an issue but yes.
  • yeastplume: It did... It's hard to see the larger picture when you're nose-down into the actual issues every day, but hope everyone can take a step back and be proud of the accomplishment when you have time to breathe.
  • jaspervdm: Excited to see the final hard fork in a few days!
  • lehnberg: Two years went by fast...
  • yeastplume: They did indeed... And sure we're all wiser And prematurely aged as a result.
    • 😂: phyro
  • lehnberg: Feels like there's so much more to do than I imagined there to be in 2019.
  • quentinlesceller: Indeed:)

2. Agenda review

The proposed agenda was accepted without changes.

3. Action point follow ups from previous meetings

None.

4. v5.0.0 status

  • lehnberg: So what's left to do ahead of... Friday's?.... Fork? We're lacking a v5.0.0 blog post on website. I can bullet out some stuff and submit that, but would be nice if a dev did it perhaps.
    • jaspervdm: I do not have great writing skills but could give it a shot.
      • 👍: jaspervdm
      • lehnberg: Great - happy to act as your editor.
        • 👍: jaspervdm
  • lehnberg: Banners have gone up. Binaries are shasumed.
  • quentinlesceller: Yeah the blog post is the missing. Along with a forum post maybe.
  • lehnberg: Is it a matter of just staying in our fox holes waiting? Any last minute testing of 5.0.1 node and 5.0.2 wallet we want to do?
  • jaspervdm: Don't think we need to do additional testing, just have to make sure the binaries will work on snap.
  • quentinlesceller: I'm deploying grin v5 on grinmint and will also do several tests.
  • quentinlesceller: I have my hand on a macbook m1 hopefully we can fix grin to compile on it.
    • 👍: yeastplume, joltz
  • lehnberg: Nice. Also add to brew right? Or is that an automatic process?

5. Priorities after the hard fork

  • jaspervdm: There's some wallet issues that I plan to look into soon.
  • yeastplume: True, though I don't think anyone will be doing any real planning just now, but perhaps what might be in people's heads about what's next? Or is everyone too exhausted with it?
  • joltz: Personal hopes once hf is behind us:
    1. tor support for nodes
    2. multisig support for wallet
    3. one-time use slatepack addresses for wallet.
    • 👍: lehnberg
  • lehnberg: Maybe we could see if we could come up with like the top 3 or top 5 big ticket items moving forward.
  • lehnberg: - parallel ibd.
    • 👍: quentinlesceller, joltz
  • lehnberg: - the exploration of two step transactions is in embryonic/research stage so I wouldn't call it out in this context, it would need to mature significantly, but would be good to drive that forward in a r&d stream that's separate from development.
  • jaspervdm: After pibd, I have a restructure of the wallet in mind that would better separate tx building, signing and transport layers. This would make it much easier to add features such as mutlisig and hardware wallets.
    • 👍: quentinlesceller, yeastplume, lehnberg, phyro
  • quentinlesceller: Usability, stability, ease of use. Also maybe wallet perf when you have thousands of tx.
    • 👍: joltz
  • quentinlesceller: Hardware wallet would be awesome.
  • lehnberg: Yeah, hardware + good multi-sig would be killers. We have a few threshold experts in the team now. :)
  • phyro: I'd love to see an aggregator access from the wallet.
    • lehnberg: What's this?
    • phyro: Just an aggregation service with an interface to send the tx to it.
    • lehnberg: Daily / hourly etc? Centralized server?
    • phyro: Oh yes, sorry, the daily:)
      • 👍: lehnberg
  • quentinlesceller: Support for view key in the wallet.
  • yeastplume: A better separation of the db layer from the wallet with support for sql backends, that could move a lot of querying into the db layer.
    • 👍: jaspervdm, joltz, quentinlesceller
  • jaspervdm: Yeah, thats definitely something we should pick back up.
  • yeastplume: Would make for more robust exchange wallets as well.
  • lehnberg: What about the light node that is @phyro's love child?
  • jaspervdm: Definitely, they could use something like postgres.
  • quentinlesceller: Also on a more technical side update on libsecp256k1 lib and maybe the one repo to rule them all thing with revamped integration tests.
    • 👍: lehnberg, phyro, joltz, jaspervdm
    • lehnberg: Good one.
    • jaspervdm: Yep, there's a bunch of merged prs on the bitcoin libsecp that we could integrate.
    • quentinlesceller: Yeah we should probably fork the original repo and reapply the changes if possible.
  • yeastplume: Always more integration testing needed.
  • jaspervdm: Agreed.
  • phyro: Careful not to overflow the bucket 👀
  • jaspervdm: Well this is just a wishlist.
  • yeastplume: Just a big brainstorm right now, the bucket has infinite capacity. What happened to flyclient talk btw?
  • jaspervdm: I think antioch was going to look more into that.
  • tromp: I wish for having payment proofs by default for all flows.
    • 👍: phyro
  • tromp: And payjoins
    • 👍: joltz
  • lehnberg: So far, what I have on wishlist
    - tor support for nodes
    - multisig support for wallet
    - one-time use slatepack addresses for wallet
    - pibd
    - multi-sig
    - hardware wallets
    - high load wallet perf (1000s of tx)
    - wallet view key
    - sql backend
    - light node
    - libsecp fork update
    - flyclient
    - payjoins
    - aggregators
    
  • lehnberg: Right what happened to all those wallet rfcs and attacks and what not?
    • joltz: Probably worth spending some timer hardening around this too.
  • jaspervdm: We also might want to think if there's a way for us make the life of potential exchanges that want to integrate grin easier.
    • 👍: lehnberg, quentinlesceller, phyro
  • tromp: Block archive node support.
    • 👍: lehnberg
  • jaspervdm: Now that we've settled on a tx building mechanism.
  • quentinlesceller: Yep definitely.
  • lehnberg: Ughhh so much stuff. 🥲 Rip.
    • quentinlesceller: Yeah lol...
    • yeastplume: Heh, lol.
  • joltz: Might as well so it can be done under less stress than if it were actively being attacked:)
  • yeastplume: No shortage of things.
  • lehnberg: So maybe let's keep a github issue or something where we can throw things on the wall as wishes and then for next meeting we can try to sort by priority?
    • 👍: joltz, jaspervdm, quentinlesceller
  • phyro: The anchor replay mitigation would require first having the payment proofs, safe cancel and payjoins anyway so it's far away probably if it was considered.
  • lehnberg: And see what we realistically can bite off first?
  • lehnberg: I see no point in trying a full year roadmap again, more like a q1/q2 attack list or something.
  • paouky: side note task (just joined) - cleaning up issues.
    • 👍: quentinlesceller
  • lehnberg: Now that we have no pesky forking to worry about, do we still want to stick with this six month cadence? Or should we look to do sth different?
  • jaspervdm: As in major releases?
  • lehnberg: Yeah, like dev / release cycles.
  • yeastplume: That's a good question. There are some very large conversations that we can have now around this and how we organise ourselves.
  • lehnberg: Not saying we need to work in sprints, but could be good to have some milestones to target.
  • jaspervdm: Yeah there's different models. Either we release major versions at regular intervals.
  • jaspervdm: Or we base them around big features.
  • lehnberg: I tend to be a fan of the former. In my experience the latter leads to stuff never being ready for release. I.e. Better to have a release cycle (whatever that is), and if you make the cut, your feature is in, if not it goes into next release. But prob getting ahead of ourselves here.
  • jaspervdm: Yeah tend to agree, but its something to think more about.
  • lehnberg: Yep, we could very well decide to do it differently. We're not building a conventional mobile app here. And we're not a dev shop.
  • yeastplume: Not a lot conventional here. Is this something that ties in with a wider governance discussion?
  • yeastplume: Anyhow, I think everyone's tired and needs a break, but I think from a dev perspective, we have a nice high-level no commitment wish-list, which is about all we can hope for right now.
    • 👍: lehnberg, jaspervdm, joltz, phyro, quentinlesceller
  • lehnberg: Wish list idea gathering issue: #385. Feel free to add in the comments as ideas come up.

6. Other questions

6.1 Anything urgent post HF4

lehnberg: Any urgent fire that's burning that we need to tend to immediately once fork is successful? Any eta for the fork on friday, trying to understand time and whether I can be available.

  • joltz: I saw something about tradeogre having v5 issues, was that resolved?
  • lehnberg: I provided my email in the hopes of getting more info. Nothing yet.
    • 👍: joltz

6.2 Fork party

  • lehnberg: Are we doing a fork keybase party / on call in case shit breaks?
    • quentinlesceller: Yep all be there hf is happening around 11:30 pm utc on friday.
  • joltz: @quentinlesceller we better make some new party parrots.
  • quentinlesceller: Indeed haha.
  • lehnberg: Oh shit, pm.
  • yeastplume: We could all get on zoom and stare awkwardly at each other.
    • 😂: joltz, phyro, lehnberg, quentinlesceller
  • lehnberg: Thought am. Haha it's vodka night...
  • tromp: Cuckaroo29 is now down to 1% fraction of blocks.
    • 👍: yeastplume
  • yeastplume: The aviary is being culled. With a much less diverse bird population.
  • tromp: Survival of the asicest.
  • yeastplume: Anyhow, on that note, I think that brings us to the end of the formal portion of our meeting. Thanks again everyone for all of your hard work over the past 3.5-4 years, and long may it continue!
  • joltz: Thanks @yeastplume!!
  • jaspervdm: Thanks! 👋
  • lehnberg: Thanks @yeastplume! 👋
  • phyro: 👋

Meeting adjourned.