From 660eaa6f58ff395418db9ec9eb08c923cfbb66aa Mon Sep 17 00:00:00 2001 From: XuanYang-cn Date: Thu, 16 Jun 2022 10:00:01 +0800 Subject: [PATCH] Extend grpcio version requirements range To run pymilvus, we only need `grpcio` To generate python files from protos, we need `grpcio-tools` This PR: 1. Removes `grpcio-tools` from install requirements 2. Extends `grpcio` versions 3. Provides the compatible version ranges of `grpcio-tools` and `grpcio` See also: #1030, #943, #946 Signed-off-by: XuanYang-cn --- README.md | 2 ++ requirements.txt | 8 ++++---- setup.py | 3 +-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 1b7703d2a..a59831486 100644 --- a/README.md +++ b/README.md @@ -53,6 +53,8 @@ $ git sumodule update --init Q2. How to generate python files from milvus-proto? +**Before generating python files, please install requirements in `requirements.txt`** + A2. ```shell $ make gen_proto diff --git a/requirements.txt b/requirements.txt index 62450fb03..1852c42ec 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,9 +1,9 @@ build==0.4.0 certifi==2021.5.30 chardet==4.0.0 -grpcio==1.37.1 -grpcio-testing==1.37.1 -grpcio-tools==1.37.1 +grpcio>=1.37.1 +grpcio-testing>=1.37.1 +grpcio-tools>=1.37.1,<=1.43.0 idna==2.10 mmh3>=2.0,<=3.0.0 packaging==20.9 @@ -28,7 +28,7 @@ sphinxcontrib-qthelp==1.0.2 sphinxcontrib-serializinghtml==1.1.3 sphinxcontrib-napoleon sphinxcontrib-prettyspecialmethods -pytest==5.3.4 +pytest>=5.3.4 pytest-cov==2.8.1 pytest-timeout==1.3.4 pylint==2.4.4 diff --git a/setup.py b/setup.py index 1706b7f1f..fa2f4f289 100644 --- a/setup.py +++ b/setup.py @@ -19,8 +19,7 @@ packages=setuptools.find_packages(), include_package_data=True, install_requires=[ - "grpcio==1.37.1", - "grpcio-tools==1.37.1", + "grpcio>=1.37.1", "ujson>=2.0.0,<=5.1.0", "mmh3>=2.0,<=3.0.0", "pandas==1.1.5; python_version<'3.7'",