-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sarc 368 loki connect #139
base: master
Are you sure you want to change the base?
Conversation
…-loki-connect # Conflicts: # poetry.lock
J'ai renoncé à tester de bout en bout le logger vers loki, de part la difficulté à utiliser |
sarc/logging.py
Outdated
config_log_level = logging_levels.get( | ||
config().logging.log_level, logging.WARNING | ||
) | ||
verbose_log_level = verbose_levels.get(verbose_level, config_log_level) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem now is that verbose_level will always override the config log level even if set with the command line. A solution would be that verbose_level
is set to None
when not specified in cmdline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, you're right.
Fixed in ab430fe
Command-line has priority if specified (-v
or -vv
); config-file log level is used otherwise.
This PR adds an opentelemetry logging handler that sends logs to a loki endpoint.
Related settings added in the
logging
section of the settings JSON file: