New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua plugin: Fix selection API using 0-based indices #435

Merged

mikke89 merged 1 commit into mikke89:master from ShawnCZek:lua-input-selection-indices

Mar 26, 2023

Contributor

ShawnCZek commented Mar 26, 2023

This is a fix for my Lua rookie mistake in #434.

Since the selection range consists of an index/offset, it should be 1-based, as this is a convention in Lua.


          Lua plugin: Fix selection API using 0-based indices

972df3b

ShawnCZek mentioned this pull request

Lua API reference: Add text selection API mikke89/RmlUiDoc#19

Merged

mikke89 added the Lua label

Owner

mikke89 commented Mar 26, 2023

Makes sense with one-indexing, and no worries :) Thanks for the PR.

mikke89 merged commit 3dc8ec5 into mikke89:master

ShawnCZek deleted the lua-input-selection-indices branch

March 26, 2023 17:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Lua