Change outdated chobo-shl containers to the ones from itlib #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iboB
changed the title
|
Hey, and thanks for the PR, I see that you are the author of the library. While I have been maintaining the chobo-shl containers as needed, I would be glad to swap it for something more actively maintained and tested. I took a look at it, and it seems like almost all the changes I've made to chobo are are already fixed, so that is good. The only exception, and feature I would miss, is the empty-base optimization for the comparison object: What do you think about adding this to the itlib library? |
|
That's a pretty good idea. I'll add it and update the PR. Thanks |
|
Ok. Done in the latest commit. Thanks for the idea! |
|
Tested this now, and everything seems to be working well. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chobo-shl is no longer supported. Its successor is itlib
This PR changes the containers used from chobo-shl to the ones from itlib which include minor improvements and fixes.
The license information is changed to reflect the state and instead of two separate licenses for
flat_mapandflat_seta single one was used: https://github.com/iboB/itlib/blob/master/LICENSE.txt