Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmake): create library alias #394

Merged
merged 2 commits into from
Dec 20, 2022
Merged

feat(cmake): create library alias #394

merged 2 commits into from
Dec 20, 2022

Conversation

cathaysia
Copy link
Contributor

Signed-off-by: Longtao Zhang [email protected]

add library alias, such as Rml::Core, Rml::Lua, and etc.

@cathaysia
Copy link
Contributor Author

I wanna know that what's the function of

export(TARGETS ${RMLUI_EXPORTED_TARGETS}
,can this be delted?

@mikke89
Copy link
Owner

mikke89 commented Dec 19, 2022

Hi, and thanks for the pull request.

I think I'd prefer it if we used the namespace RmlUi, then we would refer to e.g. RmlUi::Core. This is more consistent with e.g. our vcpkg name which uses rmlui.

Another minor issue: The rest of the file is using tabs for indentation, for consistency it would be better to change it to the same.

I wanna know that what's the function of

export(TARGETS ${RMLUI_EXPORTED_TARGETS}

,can this be delted?

I think this generates the exported targets, so the library can be imported from the build directory. I don't think we should delete this.

@mikke89 mikke89 added the build Build system and compilation label Dec 19, 2022
@mikke89 mikke89 merged commit 7986fb7 into mikke89:master Dec 20, 2022
@mikke89
Copy link
Owner

mikke89 commented Dec 20, 2022

Great, thank you!

@cathaysia cathaysia deleted the cmake branch December 20, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system and compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants