Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Where to implement reserved keyword check? cds-dbm or cds-pg #181

Open
gregorwolf opened this issue Apr 7, 2022 · 3 comments
Open

Where to implement reserved keyword check? cds-dbm or cds-pg #181

gregorwolf opened this issue Apr 7, 2022 · 3 comments

Comments

@gregorwolf
Copy link
Collaborator

In #179 this issue was identified:

But 'user' turns out to be a reserved keyword in Postgresql.
https://www.postgresql.org/docs/current/sql-keywords-appendix.html
Might be an idea to scan for those and give a warning ?

the question is where do we implement this? in cds-dbm or cds-pg.

@gregorwolf
Copy link
Collaborator Author

What do you think @vobu?

@vobu
Copy link

vobu commented Apr 8, 2022

I'd vote for both:

  • in cds-pg when serving any .cds that contains user as an entity
  • in cds-dbm at deploy-time

@sedacrivity
Copy link

Great. It could also be nice to include a warning on the combined length of a table / view exceeding the hard limit of 63 characters. See #180

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants