Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't close chrome #43

Open
AlexandrMoruk opened this issue Nov 29, 2018 · 3 comments
Open

Can't close chrome #43

AlexandrMoruk opened this issue Nov 29, 2018 · 3 comments
Assignees

Comments

@AlexandrMoruk
Copy link

Hello! I use your library to collect images from captcha, but the browser does not close. Function cleanup() is called, writes a log 'Browser closed', but browser.close() doesn't work.

@AlexandrMoruk
Copy link
Author

I was mistake in the description, the browser is chromium

@mikeyy
Copy link
Owner

mikeyy commented Dec 6, 2018

Hello, I will look into this and get it sorted out. What operating system did this occur on?

@mikeyy mikeyy self-assigned this Dec 6, 2018
@AlexandrMoruk
Copy link
Author

Hello? sorry for the delay, Ubuntu 18.04, I am not sure but function Browser.create in launcher.py passes argument self.killChrome to the fourth, and must a six. Sorry for my English)

@staticmethod
   async def create(connection: Connection, contextIds: List[str],
                    ignoreHTTPSErrors: bool, appMode: bool,
                    process: Optional[Popen] = None,
                    closeCallback: Callable[[], Awaitable[None]] = None,
                    **kwargs: Any) -> 'Browser':
       """Create browser object."""
       browser = Browser(connection, contextIds, ignoreHTTPSErrors, appMode,
                         process, closeCallback)
       await connection.send('Target.setDiscoverTargets', {'discover': True})
       return browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants