You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're querying for the list owner, but we shouldn't need it?
I changed set_list in the lists_controller to @list = current_user.all_lists.find_by(slug: params[:id]), but then tests were failing and I'm not really sure what the logic is supposed to be.
We can either update the logic based on how we're using the app, or if we still need that logic, do an includes to eliminate the N+1 queries, or could cache it since lists change infrequently.
The text was updated successfully, but these errors were encountered:
app/views/layouts/_header.html.erb:47
We're querying for the list owner, but we shouldn't need it?
I changed
set_list
in thelists_controller
to@list = current_user.all_lists.find_by(slug: params[:id])
, but then tests were failing and I'm not really sure what the logic is supposed to be.We can either update the logic based on how we're using the app, or if we still need that logic, do an
includes
to eliminate the N+1 queries, or could cache it since lists change infrequently.The text was updated successfully, but these errors were encountered: