Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for neovim v0.9 #60

Merged
merged 15 commits into from
Nov 24, 2023
Merged

feat: add support for neovim v0.9 #60

merged 15 commits into from
Nov 24, 2023

Conversation

jackielii
Copy link
Contributor

@jackielii jackielii commented Nov 22, 2023 •
edited
Loading

This PR vendors vim.system for neovim < v0.10 to work.

Notes:

  1. vim.uv is not available in <v0.10, however, it seems vim.system is only using standard libuv functions
  2. I didn't touch the version check code. Please feel free to modify

Also I didn't do thorough tests as I'm only just adopting this awesome tool! Kudos!

for #58

@jackielii jackielii changed the title vendor vim system vendor vim system for #58 Nov 22, 2023
@jackielii jackielii changed the title vendor vim system for #58 vendor vim system Nov 22, 2023
@mikesmithgh mikesmithgh changed the title vendor vim system feat: add support for neovim v0.9 Nov 22, 2023
@mikesmithgh
Copy link
Owner

thanks! is this working for you locally? if so what version of Neovim are you on?

I'll circle back to this later today or sometime tomorrow. Thanks for the contribution 👍

@jackielii
Copy link
Contributor Author

thanks! is this working for you locally? if so what version of Neovim are you on?

I'll circle back to this later today or sometime tomorrow. Thanks for the contribution 👍

I'm on v0.9.4, yes it's working smoothly so far!

@mikesmithgh
Copy link
Owner

hey @jackielii I think this PR is looking pretty good. I modified things a bit. Could you run KittyScrollbackCheckHealth on your v0.9.4 nvim version and let me know if it runs successfully? Thanks! I need test a couple more things but think this should be good in the next day or two to merge.

@jackielii
Copy link
Contributor Author

Nice! Just tested it and everything looks good! thanks!

mikesmithgh
mikesmithgh approved these changes Nov 24, 2023
View reviewed changes
Copy link
Owner

@mikesmithgh mikesmithgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 :shipit:

@mikesmithgh mikesmithgh merged commit 30fffc0 into mikesmithgh:main Nov 24, 2023
2 checks passed
mikesmithgh pushed a commit that referenced this pull request Nov 24, 2023
@semantic-release-bot
chore(release): 2.2.0
8cdd64f 
# [2.2.0](v2.1.2...v2.2.0) (2023-11-24)

### Features

* add support for neovim v0.9 ([#60](#60)) ([30fffc0](30fffc0))
@mikesmithgh
Copy link
Owner

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mikesmithgh
Copy link
Owner

closes #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesmithgh mikesmithgh mikesmithgh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackielii @mikesmithgh