Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postponeEnterTransition() does not work in "Picasso Fragment to Fragment" sample. #8

Open
aartikov opened this issue Apr 21, 2017 · 5 comments

Comments

@aartikov
Copy link

Calling of a method postponeEnterTransition() has no effect. To check it remove startPostponedEnterTransition() calls in a Picasso callback. A transition will be still plays, but it should not. Documentation says: "Likewise, postponement only works if FragmentTransaction optimizations are enabled." So, to fix the sample call setAllowOptimization(true) of a FragmentTransaction.

@Rainer-Lang
Copy link

@aartikov Do you want to make a PR?

@aartikov
Copy link
Author

aartikov commented Jul 7, 2017

@Rainer-Lang No, i don't. It is looks like that this repository is abandoned.

@mikescamell
Copy link
Owner

@aartikov It's not abandoned, I'm just pretty busy at the moment. Feel free to make a PR.

@aartikov
Copy link
Author

aartikov commented Jul 7, 2017

@mikescamell done #11

@mikescamell
Copy link
Owner

@aartikov I'm going to need to look into this more as turning the optimisation on has an effect on the Shared Element Transitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants