-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with ender js #646
Comments
Yeah, you are totally right. I just read through the 'ender.js' docs and it seems there is no way to release control of the Rivets was written in 2012, and I am sure that at the time, the Anyways, you are correct that there should be a way to opt out of this auto detect jQuery behavior as other libs will eventually want control of the If we were able to make this jQuery or no jQuery business a little better I think we could also resolve this issue: #641 I think some of the other core members should comment here and gauge interest. |
Ender.js is intended to be a lightweight jQuery replacement; the code in rivets works fine if it uses the $ function provided by ender, the issue is it looks for $ || jQuery then uses jQuery |
Why not always use addEventListener? |
See my comment here. Maybe it can help you? |
I use http://minifiedjs.com/ and sometimes (rarely) rivets can't initialize because As @carnage explained it checks for |
@Duder-onomy wouldn't it make sense to merge #679 until next decisions about jQuery are made? |
When used with Ender Js, there is an error on load. It is due to ender registering the $ function which is being detected in https://github.com/mikeric/rivets/blob/master/src/util.coffee
Several options for a fix.
You could prevent the usage of jquery bindings if the ender function is defined
You could use $ to bind the methods instead of jQuery
or You could use (window['jQuery'] || window['$']) to create your methods, matching the if statement.
The text was updated successfully, but these errors were encountered: