buildBinding regex breaks with multiple strings

[agmonks]

This is broken in 0.9 (fixed as part of #432)

/((?:'[^']*')*(?:(?:[^\|']+(?:'[^']*')*[^\|']*)+|[^\|]+))|^$/g

This breaks for the following example (not picking up the 2nd string):

receiptTypeId | lookup reciptTypes 'value' 'key'

I'm trying to come up with a working regex but I'm not great at regex!

[jccazeaux]

Damn, didn't see that 😞
I found a better regexp. It works fine but returns empty strings. Didn't find a way to eliminate these in the regexp. So i eliminated them with a filter. PR will follow, if anyone has a better idea i'll happy to see it !

[agmonks]

I came up with the same regex issues with the empty spaces. Would recommend not using filter as for loop would work quicker (don't think the extra checks filter runs are needed here)

[jccazeaux]

I agree, the code is work in progress. I hoped someone could help to find THE regexp ;-)
In the meantime feel free to propose a better/faster solution.

[agmonks]

How about:

((?:'[^']*')*(?:(?:[^\|']*(?:'[^']*')+[^\|']*)+|[^\|]+))|^$

[jccazeaux]

Looks great!
I'll close m'y PR, feel free to send a PR with your solution (won't be able to do it until 2 weeks)

[agmonks]

@Leeds-eBooks This issues probably justifies a 0.9.1 release (as it might break other peoples apps like mine)?

[benadamstyles]

0.9.1 published!

[agmonks]

Excellent! Thanks

[agmonks]

@Leeds-eBooks FYI I have also created a ES6 fix (PR #626) as well (also had to fix up the testing framework in PR #625)

[jccazeaux]

Great ! Thanks !