Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested rv-if don't rebind correctly #611

Closed
jccazeaux opened this issue Apr 18, 2016 · 5 comments
Closed

Nested rv-if don't rebind correctly #611

jccazeaux opened this issue Apr 18, 2016 · 5 comments

Comments

@jccazeaux
Copy link
Contributor

Hi all

I recently encountered this issues :
Consider this DOM

  <div rv-if="scope.firstDiv">
    <div rv-if="scope.secondDiv">
      <input rv-value='scope.data2'>{ scope.data2 }
    </div>
  </div>

If scope.firstDiv is set to false then true the secondDiv if correctly shwon but databinding is lost.
You can test it there : https://jsfiddle.net/jccazeaux/ou483fdj/
As you can see, databinding is lost when we toggle the level 1. To activate the databinding again we have to toggle the level 2.

This is a glitch in rv-if binder which doesn't reinit a bound flag. PR will follow

@jccazeaux
Copy link
Contributor Author

That was fast 😄

@benadamstyles
Copy link
Collaborator

:) I'm trying to get back on top of things. Do you think we're ready for a new version, and if so, do you know how we go about it?

@jccazeaux
Copy link
Contributor Author

I think we're ready for a 0.9. There was many updates since 0.8.1 and it's worth a release.
I don't think we leave important issues behind for now. I know there is still work on components but it can wait for a next release.
How we go about it? Well I don't really know. First we must synthetize all PR for the release notes (already done in issue #560) . Then build and go.

@benadamstyles
Copy link
Collaborator

benadamstyles commented Apr 18, 2016

Ok, could you add your recent PRs to the list in #560? Then after adding these to a changelog, I will look into how we push a new version.

@jccazeaux
Copy link
Contributor Author

Done. I'll take some time to make sure no PR was missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants