Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in 0.7.1 #430

Closed
jccazeaux opened this issue Dec 5, 2014 · 19 comments
Closed

Memory leak in 0.7.1 #430

jccazeaux opened this issue Dec 5, 2014 · 19 comments

Comments

@jccazeaux
Copy link
Contributor

Hi

I've done the upgrade from 0.6.9 to 0.7.1. Since i noticed some memory leak. The objects seem to be retained after unbind.
I made a jsfiddle with a very basic bind/unbind. In the model i put a very big String (~5MB) so we can clearly see the allocations and deallocations.

example with 0.6.9 : http://jsfiddle.net/jccazeaux/v6x47k6k/

In the chrome profiler we can see that the objects are correctly freed:
image

Same code with 0.7.1 : http://jsfiddle.net/jccazeaux/v6x47k6k/2/

In the chrome profile we see that the objects are retained. The memory is growing.
071

To test it, just start the "Record heap allocation" profiling type and click alternatively on "bind" and "unbind".

@jhnns
Copy link
Contributor

jhnns commented Dec 5, 2014

Yep, that looks like a memory leak...

@bharatpatil
Copy link

Should I downgrade?

@JakeHP
Copy link

JakeHP commented Jan 3, 2015

Yikes..

@mikeric
Copy link
Owner

mikeric commented Jan 3, 2015

Looks like this issue was opened after #421 had already been merged in.

@jccazeaux Can you please verify that this is in fact an issue on master? I was already aware of the memory leak in the current release (0.7.1), which has been addressed in #421.

@mikeric
Copy link
Owner

mikeric commented Jan 3, 2015

Closing this. I've released 0.7.2 which includes #421.

@mikeric mikeric closed this as completed Jan 3, 2015
@jccazeaux
Copy link
Contributor Author

I was unavailable until today. I verified the 0.7.2 and it doesn't seem to solve the problem. Here is the jsfiddle with 0.7.2 : http://jsfiddle.net/4tprm3ny/2/

@docluv
Copy link

docluv commented Jan 14, 2015

I verified the leak in jccazeaux's JSFiddle using IE's memory profiling. You can see the memory building up from the base of 3.5MB (JSFiddle baseline) to 13+MB after the bind. The bound data is not released and only compounds as you bind and unbind.
Rivets Memory Leak

@jccazeaux
Copy link
Contributor Author

This issue should be reopened

@mikeric
Copy link
Owner

mikeric commented Jan 19, 2015

@jccazeaux, @docluv Thanks for reproducing the leak on 0.7.2. Reopening this, will take a look next chance I get.

@mikeric mikeric reopened this Jan 19, 2015
@JakeHP
Copy link

JakeHP commented Jan 20, 2015

Thanks @mikeric

@jhnns
Copy link
Contributor

jhnns commented Jan 20, 2015

👍

@jccazeaux
Copy link
Contributor Author

Thanks

@AMTourky
Copy link

Still occurs at 0.8.0
my object is pretty big, and leaking tons of memory

@JakeHP
Copy link

JakeHP commented Feb 18, 2015

Good catch @AMTourky

@AMTourky
Copy link

Thanks @JakeHP

@jccazeaux
Copy link
Contributor Author

Found the solution in sightglass : mikeric/sightglass#10

@JakeHP
Copy link

JakeHP commented Apr 26, 2015

Good job @jccazeaux!

@jhnns
Copy link
Contributor

jhnns commented Apr 26, 2015

👍

@nopnop
Copy link

nopnop commented Jun 11, 2015

Nice catch @jccazeaux,
@mikeric : any plan to fix this issue soon ?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants