Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Remove System.Data.SqlClient reference from RepoDB.SqlServer #857

Closed
Dean-NC opened this issue Aug 27, 2021 · 2 comments
Closed

Enhancement: Remove System.Data.SqlClient reference from RepoDB.SqlServer #857

Dean-NC opened this issue Aug 27, 2021 · 2 comments
Assignees
@mikependon
Labels
enhancement New feature or request fixed The bug, issue, incident has been fixed. priority Top priority feature or things to do request A request from the community. todo Things to be done in the future

Comments

@Dean-NC
Copy link

Dean-NC commented Aug 27, 2021

Describe the enhancement

Since RepoDB.SqlServer already has a reference to Microsoft.Data.SqlClient, it would be nice to not also have a reference to System.Data.SqlClient. Currently, the output (bin) folder of an application using RepoDB.SqlServer will have assemblies and dependencies for both Microsoft.Data.SqlClient AND System.Data.SqlClient.
@Dean-NC Dean-NC added the enhancement New feature or request label Aug 27, 2021
@mikependon
Copy link
Owner

This is true and I agree to this as well. Though it is easy to remove the references towards the SDS, but it is not as simple as that. We are afraid that we might affect some of the users if we are to remove this without the proper acceptance from the community.

Maybe, I will bring this question to the community itself and will ensure this will be implemented on the next releases.

@mikependon mikependon added the request A request from the community. label Aug 28, 2021
@mikependon mikependon added priority Top priority feature or things to do todo Things to be done in the future labels Sep 11, 2021
@mikependon mikependon pinned this issue Sep 11, 2021
mikependon added a commit that referenced this issue Sep 11, 2021
@mikependon
#857 - Deprecated both the MicrosoftSqlServerTypeMapAttribute and Sys…
b6e77a7 
…temSqlServerTypeMapAttribute.
mikependon added a commit that referenced this issue Sep 11, 2021
@mikependon
#857 - Added the necessary attributes for the MDS.
edafa5a
mikependon added a commit that referenced this issue Sep 11, 2021
@mikependon
#857 Added the obsolete attribute to the bootstrapper to relay the me…
f77e68d 
…ssage.
mikependon added a commit that referenced this issue Sep 24, 2021
@mikependon
Complete removal of the System.Data.SqlClient.
cadaf1e 
- Enhancement: Remove `System.Data.SqlClient` reference from RepoDB.SqlServer [#857](#857)
- Removed the `MicrosoftSqlServerTypeMapAttribute` attribute.
- Removed the `SystemSqlServerTypeMapAttribute` attribute.
@mikependon mikependon added the fixed The bug, issue, incident has been fixed. label Sep 24, 2021
@mikependon mikependon mentioned this issue Sep 24, 2021
Merged
@mikependon
Copy link
Owner

The System.Data.SqlClient will be removed on the next version of RepoDb.SqlServer (or > v1.1.4).

@mikependon mikependon unpinned this issue Sep 25, 2021
mikependon added a commit that referenced this issue Sep 25, 2021
@mikependon
#857 Fixed the failing Integration Tests on the Core.
9574cd6
mikependon added a commit that referenced this issue Sep 25, 2021
@mikependon
#857 Complete removal of the System.Data.SqlClient from the RepoDb.Sq…
de772d4 
…lServer.BulkOperations.
mikependon added a commit that referenced this issue Sep 25, 2021
@mikependon
Merge pull request #932 from mikependon/repodb-enhancements
7bfdbb6 
#857 Complete removal of the System.Data.SqlClient from the RepoDb.SqlServer.BulkOperations.
@w5l w5l mentioned this issue Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikependon mikependon

Labels
enhancement New feature or request fixed The bug, issue, incident has been fixed. priority Top priority feature or things to do request A request from the community. todo Things to be done in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikependon @Dean-NC