Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atomic changefeeds instead of extra non-realtime initial query #20

Closed
mikemintz opened this issue Nov 12, 2015 · 1 comment · Fixed by #21
Closed

Use atomic changefeeds instead of extra non-realtime initial query #20

mikemintz opened this issue Nov 12, 2015 · 1 comment · Fixed by #21

Comments

@mikemintz
Copy link
Owner

Now that RethinkDB 2.2 has been released with atomic changefeeds, we can make our changefeed logic much simpler and more robust. See the TODO notes in QueryState.js.

This will probably make react-rethinkdb incompatible with older versions of RethinkDB, at least for changefeed queries. But I consider that an acceptable tradeoff, given that this solves the possible race conditions we had.

We'll need to make sure we can fail fast on old versions of RethinkDB running in the backend. I haven't looked at the API for atomic changefeeds, but hopefully it's something that will be rejected by RethinkDB 2.1 as opposed to fulfilled incorrectly.

@mikemintz
Copy link
Owner Author

I created PR #21 with atomic changefeed functionality.

I'll test it thoroughly when rethinkdb 2.2 packages hit arch linux and npm, and probably upgrade rethinkdb-websocket-client first so we get the 2.2 driver too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant