Skip to content
This repository has been archived by the owner on Mar 21, 2018. It is now read-only.

Ability to modify sapi array #26

Open
freezedriedpop opened this issue Sep 4, 2013 · 4 comments
Open

Ability to modify sapi array #26

freezedriedpop opened this issue Sep 4, 2013 · 4 comments
Assignees

Comments

@freezedriedpop
Copy link

As far as I can tell this will only ever look for files called:

log-apache*-
log-cli-
log-cgi-fcgi
log-fpm-fcgi

And as far I can also tell this is defined in the languages file so there's no proper way to modify through the config.

Is it possible to add something to this array and if not can I request the ability to add custom log files as a new feature?

@mikemand
Copy link
Owner

mikemand commented Sep 4, 2013

I've been looking into ways to deal with the inability to override language files, but have so far come up with nothing. I guess the only solution would be to move the SAPI strings into the config file.

I want to support as many of the SAPIs as I can, out of the box. Do you have one that isn't in the current list?

@freezedriedpop
Copy link
Author

It was mainly because i've been creating a separate log file called log-404-{date}.txt so that I could go through and check the not found errors separately and wanted to include that. I extended the Log class to create that 404 file and I was thinking about modifying your logviewer to include it.

While I realise my use case may be a bit more unique I thought it might be worthwhile suggesting that it be made more flexible for any use. I think a config array for the SAPIs as well as for types (Error, Alert, Critical etc) would be really good. Of course the default can just be what's there so out of the box it works the same, while also allowing for easier customisation and compatibility should one modify Laravels built in logging behaviour.

@mikemand
Copy link
Owner

Sorry there hasn't been any movement on this. I'm currently really bogged down with my day job. I'll get a solution worked out as soon as I can.

@mikemand
Copy link
Owner

I haven't forgot about you @freezedriedpop.

I opened a request for the ability to override language files here: laravel/framework#2384

I'm still trying to figure out what Taylor means...

@ghost ghost assigned mikemand Feb 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants