From fae3b363ecd8c8e02720c02da2dc6d8613a7403b Mon Sep 17 00:00:00 2001 From: Kamil Mysliwiec Date: Fri, 22 Feb 2019 11:08:05 +0100 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 364656a248..71824d9300 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -51,19 +51,6 @@ and help you to craft the change so that it is successfully accepted into the pr Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available. -We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs we will systematically ask you to provide a minimal reproduction scenario using a repository or [Gist](https://gist.github.com/). Having a live, reproducible scenario gives us wealth of important information without going back & forth to you with additional questions like: - -- version of NestJS used -- 3rd-party libraries and their versions -- and most importantly - a use-case that fails - - - - - Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that don't have enough info to be reproduced. You can file new issues by filling out our [new issue form](https://github.com/nestjs/nest/issues/new). @@ -207,26 +194,6 @@ Must be one of the following: * **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) * **test**: Adding missing tests or correcting existing tests -### Scope -The scope should be the name of the npm package affected (as perceived by person reading changelog generated from commit messages. - -The following is the list of supported scopes: - -* **common** -* **core** -* **sample** -* **microservices** -* **testing** -* **websockets** - -There are currently a few exceptions to the "use package name" rule: - -* **packaging**: used for changes that change the npm package layout in all of our packages, e.g. public path changes, package.json changes done to all packages, d.ts file/format changes, changes to bundles, etc. -* **changelog**: used for updating the release notes in CHANGELOG.md -* **sample/#**: for the example apps directory, replacing # with the example app number - -* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all packages (e.g. `style: add missing semicolons`) - ### Subject The subject contains succinct description of the change: