Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Anybar by default #122

Closed
arondeparon opened this issue Sep 28, 2018 · 3 comments
Closed

Disable Anybar by default #122

arondeparon opened this issue Sep 28, 2018 · 3 comments

Comments

@arondeparon
Copy link

arondeparon commented Sep 28, 2018

Our CI systems started generating exceptions when using the 0.20.* build. We downgraded to 0.19.14 and noticed that the error was resolved.

When comparing the differences between these versions, the biggest change is the introduction of Anybar support.

I don't have Anybar installed, and tests seem to be working fine when running them locally on my Mac Os machine, but when running them in our CI environment (Ubuntu), we get unexpected results.

TL;DR: it would probably be wise to disable it by default in the configuration.

See also laravel/framework#6322 (comment)

@mikeerickson
Copy link
Owner

My sincerest apologies, I didn’t know there would be any harm. I will post a new patch today to mark this as false by default

@mikeerickson
Copy link
Owner

mikeerickson commented Sep 28, 2018

@arondeparon Hey there, just wanted to let you know, I have tagged a new release 0.21.1 to turn this off by default. Again, my apologies on letting this slip through.

@arondeparon
Copy link
Author

No worries @mikeerickson! Can't catch every bug at once! 👍

Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants