Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree insideSandbox doesn't account for immediate parent directory #149

Open
mnutt opened this issue Jun 19, 2016 · 0 comments
Open

Tree insideSandbox doesn't account for immediate parent directory #149

mnutt opened this issue Jun 19, 2016 · 0 comments

Comments

@mnutt
Copy link

mnutt commented Jun 19, 2016

At least on node v4/v6, Path.relative returns .. when a directory is compared with its immediate parent. This will cause insideSandbox to return true even though the parent isn't inside the sandbox, since it's looking for ../. I think this can be fixed by just comparing against .. instead; I can't think of any situations where that would cause issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant