Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single instance of handler and authentication class mixes users #132

Open
austein opened this issue Jul 17, 2015 · 1 comment
Open

Single instance of handler and authentication class mixes users #132

austein opened this issue Jul 17, 2015 · 1 comment

Comments

@austein
Copy link

austein commented Jul 17, 2015

Both jsDAV_Auth_Backend_AbstractBasic and Digest classes use a currentUser to store the current successfully-authenticated user. If two users make concurrent requests, the latter's authentication is stored and used for the first user's request. DAVACL will check for permissions and reject the first request once currentUser is set to the second user.

Tested using Mac OSX Yosemite's Contacts with two accounts setup pointing at localhost. Restarting Contacts will cause one or both to fail depending on how the race condition plays out

@mikedeboer
Copy link
Owner

Very true! Pull Request super welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants