From 9a733a2739a25497f8aece8268d83d625a995f9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mike=20C=C3=B4t=C3=A9?= <mikecote@users.noreply.github.com>
Date: Wed, 6 May 2020 13:39:09 -0400
Subject: [PATCH] Shallow clone properties when adding to registry (#65309)

---
 .../server/action_type_registry.test.ts       | 13 +++++++++++++
 .../actions/server/action_type_registry.ts    |  2 +-
 .../server/alert_type_registry.test.ts        | 19 +++++++++++++++++++
 .../alerting/server/alert_type_registry.ts    |  2 +-
 4 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/x-pack/plugins/actions/server/action_type_registry.test.ts b/x-pack/plugins/actions/server/action_type_registry.test.ts
index 26bd68adfc4b6..4e0f45cffe51b 100644
--- a/x-pack/plugins/actions/server/action_type_registry.test.ts
+++ b/x-pack/plugins/actions/server/action_type_registry.test.ts
@@ -61,6 +61,19 @@ describe('register()', () => {
     `);
   });
 
+  test('shallow clones the given action type', () => {
+    const myType: ActionType = {
+      id: 'my-action-type',
+      name: 'My action type',
+      minimumLicenseRequired: 'basic',
+      executor,
+    };
+    const actionTypeRegistry = new ActionTypeRegistry(actionTypeRegistryParams);
+    actionTypeRegistry.register(myType);
+    myType.name = 'Changed';
+    expect(actionTypeRegistry.get('my-action-type').name).toEqual('My action type');
+  });
+
   test('throws error if action type already registered', () => {
     const actionTypeRegistry = new ActionTypeRegistry(actionTypeRegistryParams);
     actionTypeRegistry.register({
diff --git a/x-pack/plugins/actions/server/action_type_registry.ts b/x-pack/plugins/actions/server/action_type_registry.ts
index c1d979feacc1d..7fb88ecd8d429 100644
--- a/x-pack/plugins/actions/server/action_type_registry.ts
+++ b/x-pack/plugins/actions/server/action_type_registry.ts
@@ -75,7 +75,7 @@ export class ActionTypeRegistry {
         )
       );
     }
-    this.actionTypes.set(actionType.id, actionType);
+    this.actionTypes.set(actionType.id, { ...actionType });
     this.taskManager.registerTaskDefinitions({
       [`actions:${actionType.id}`]: {
         title: actionType.name,
diff --git a/x-pack/plugins/alerting/server/alert_type_registry.test.ts b/x-pack/plugins/alerting/server/alert_type_registry.test.ts
index b51286281571e..c21292deca087 100644
--- a/x-pack/plugins/alerting/server/alert_type_registry.test.ts
+++ b/x-pack/plugins/alerting/server/alert_type_registry.test.ts
@@ -72,6 +72,25 @@ describe('register()', () => {
     `);
   });
 
+  test('shallow clones the given alert type', () => {
+    const alertType: AlertType = {
+      id: 'test',
+      name: 'Test',
+      actionGroups: [
+        {
+          id: 'default',
+          name: 'Default',
+        },
+      ],
+      defaultActionGroupId: 'default',
+      executor: jest.fn(),
+    };
+    const registry = new AlertTypeRegistry(alertTypeRegistryParams);
+    registry.register(alertType);
+    alertType.name = 'Changed';
+    expect(registry.get('test').name).toEqual('Test');
+  });
+
   test('should throw an error if type is already registered', () => {
     const registry = new AlertTypeRegistry(alertTypeRegistryParams);
     registry.register({
diff --git a/x-pack/plugins/alerting/server/alert_type_registry.ts b/x-pack/plugins/alerting/server/alert_type_registry.ts
index a2be43f9dacbd..6b04e6b0252ba 100644
--- a/x-pack/plugins/alerting/server/alert_type_registry.ts
+++ b/x-pack/plugins/alerting/server/alert_type_registry.ts
@@ -41,7 +41,7 @@ export class AlertTypeRegistry {
       );
     }
     alertType.actionVariables = normalizedActionVariables(alertType.actionVariables);
-    this.alertTypes.set(alertType.id, alertType);
+    this.alertTypes.set(alertType.id, { ...alertType });
     this.taskManager.registerTaskDefinitions({
       [`alerting:${alertType.id}`]: {
         title: alertType.name,