-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Problem]: 100% cpu utilization and crash after network connection is interrupted and device comes back online #1870
Comments
Thanks. I'll take a look. As a matter of interest, is the Mac an Apple Silicon Mac or an Intel Mac? |
It's an intel mac. If you can't reproduce it but want to fix it anyway, please let me know if i can help (testing code, running memory dump, debugger). |
Hmm, I'm afraid I'm not getting this to happen. Here is my config:
Running macOS Ventura 13.6.7 (the latest it can use) on a 27" 2017 iMac. The config of Shairport Sync is a bit different; in particular, metadata is not enabled. Would you be kind enough to try building without metadata and see if the problem persists? (I'll keep digging myself.) |
Thank you for digging into this! I tried to build with the same options as you did and with the sample config file, but the error still occurs. Also I noticed the Unix System Calls and Process Switches counts in activity monitor go completely crazy once the cpu time is 100%.
My next steps would be to try on a fresh install of Mac OS Ventura as well as Sonoma and see if it works then. I'll try this over the next days. |
Well, I have found something. Let me look at it... |
So, I found a bug and pushed a fix [I hope!] in the |
Amazing, that fixed the error and it works perfectly now! |
Thanks for the feedback, and indeed thanks for the bug report. BTW, I've just made the session timeout two minutes by default -- one minute seems to be a bit short. |
This issue has been inactive for 28 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment. |
What happened?
When streaming from an iOS device to shairport sync in airplay mode 1 and toggling airplane mode mid-stream (or interrupting the connection otherwise, so that iOS switches back to local playback), after reconnecting the client device to the network, shairport-sync ramps up to 100% cpu utilization on one core and crashes shortly afterwards.
This also happens when setting allow_session_interruption to yes and for different values for session_timeout (e.g. 0), with the difference, that shairport-sync doesn't crash but hast 100% cpu indefinitely and no log output. Streaming still works in those cases.
Relevant log output
System Information.
Client: iPhone with iOS 17
Server: Mac OS 14.5 Sonoma with shairport-sync 4.3.3 via Homebrew
Configuration Information.
PulseAudio or PipeWire installed?
How did you install Shairport Sync?
Homebrew for Mac
Check previous issues
The text was updated successfully, but these errors were encountered: