Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service file needs to be adapted for --with-tinysvcmdns #1454

Closed
klslz opened this issue Apr 1, 2022 · 4 comments
Closed

service file needs to be adapted for --with-tinysvcmdns #1454

klslz opened this issue Apr 1, 2022 · 4 comments

Comments

@klslz
Copy link

klslz commented Apr 1, 2022

If Shairport Sync gets compiled with --with-tinysvcmdns instead of --with-avahi, the make-installed
systemd startup service file still requires the Avahi service to be present.

That makes Shairport Sync fail to start.

I'd suggest that

  1. either a 2nd systemd startup service file should get installed or
  2. the documentation should be updated

original:

[Unit]
Description=Shairport Sync - AirPlay Audio Receiver
After=sound.target
Requires=avahi-daemon.service
After=avahi-daemon.service
Wants=network-online.target
After=network.target network-online.target

[Service]
ExecStart=/usr/local/bin/shairport-sync
User=shairport-sync
Group=shairport-sync

[Install]
WantedBy=multi-user.target

needs to be

[Unit]
Description=Shairport Sync - AirPlay Audio Receiver
After=sound.target
Wants=network-online.target
After=network.target network-online.target

[Service]
ExecStart=/usr/local/bin/shairport-sync
User=shairport-sync
Group=shairport-sync

[Install]
WantedBy=multi-user.target

if compiled with --with-tinysvcmdns and Avahi not being present.

Thx for the great work btw.

@mikebrady mikebrady added the bug label Apr 4, 2022
@mikebrady
Copy link
Owner

Thanks for the report. Let's see what can be done about it...

@mikebrady
Copy link
Owner

mikebrady commented Apr 5, 2022

Thanks again for reporting this issue. An update has been pushed into the development branch which should fix this problem. The correct version of the systemd startup service file should be installed, depending on whether or not the Avahi service is required by Shairport Sync.

If you got a chance to try it out and report back, it would be appreciated.

@klslz
Copy link
Author

klslz commented Apr 5, 2022

Thx. Your commit looks awesome. I'll check later on.

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants