-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple of enhancements #41
Comments
Hey @rafalkrupinski - apologies for my slow reply here! Commented on the other issues too, but in general i'm happy to accept contributions if its enhancing/within the spirit of openapi/pydantic and maintains support for oas 3.0.x and pydantic 1 + 2. The only one I'm not sure of in the above is the ref resolver, not sure if it would bloat the surface area of the project too much to be opinionated on it, as we try to defer to Pydantic for most of the heavy lifting on the JSONSchema side. Happy to hear a suggestion if you can suggest an elegant enough API for it 👍🏼 |
Resolving references is actually quite simple.
It could be a method in OpenAPI and a couple of helper functions. |
@mike-oakley you don't think running mypy on tests is an overkill? |
+1 for a reference resolver. I am trying to extract a complete schema from a given path-method-response, and was surprised to find refs aren't currently auto-resolved. Especially given the reverse case is true; refs are added to generated json/yaml spec outputs, at least when using the |
Some enhancements I'd be happy port from my project:
str
)example
andexamples
is definedAlso, Paths could be changed tothis is validdict[str, PathItem | Reference]
, andref
could be removed fromPathItem
.content
andschema
The text was updated successfully, but these errors were encountered: