Allow user-defined separator and fix docker-compose process #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-compose up command was returning 'unable to find grunt'. The npm install command was done on the /code directory copied in the Dockerfile instead of the one mounted with volume. Now running npm install before running grunt after mounting the volume.
New field on html page for separator character (for websites that don't allow spaces in passwords). Listens to changes so user can keep the same words and just change the separator. Crack time gets recalculated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker-compose process needed some changes for grunt to be able to run.
Added a new separator field so the user can decide on a different separator character (or no character).