Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GHC 9.6 #699

Merged
merged 26 commits into from
Apr 16, 2023
Merged

Support GHC 9.6 #699

merged 26 commits into from
Apr 16, 2023

Conversation

toku-sa-n
Copy link
Collaborator

@toku-sa-n toku-sa-n commented Apr 13, 2023 •
edited by mihaimaruseac
Loading

  • Create a wrapper for ghc-lib-parser to handle different versions easily

Fixes: #697

mihaimaruseac
mihaimaruseac reviewed Apr 15, 2023
View reviewed changes
Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it worked without the last commit. Let's revert it as the macro aliases I think decrease readability

@mihaimaruseac mihaimaruseac marked this pull request as ready for review April 16, 2023 01:04
@toku-sa-n toku-sa-n marked this pull request as draft April 16, 2023 01:04
mihaimaruseac
mihaimaruseac approved these changes Apr 16, 2023
View reviewed changes
Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mihaimaruseac mihaimaruseac marked this pull request as ready for review April 16, 2023 01:05
@toku-sa-n
Copy link
Collaborator Author

Actually, this PR is still a draft. It has lots of duplicated codes, and I have to remove them.

@mihaimaruseac mihaimaruseac merged commit 4d480b8 into mihaimaruseac:master Apr 16, 2023
@toku-sa-n toku-sa-n deleted the ghc-9.6 branch April 16, 2023 01:06
@toku-sa-n toku-sa-n restored the ghc-9.6 branch April 16, 2023 01:06
@mihaimaruseac
Copy link
Owner

Oh, my bad :( I thought it was gone and it was timezone difference

@toku-sa-n
Copy link
Collaborator Author

No, it's because of my computer's broken clock :)
Anyway, I'll send another PRs to continue refactoring.

@toku-sa-n toku-sa-n deleted the ghc-9.6 branch April 16, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.3.4 fails to build with mtl-2.3.1
2 participants
@toku-sa-n @mihaimaruseac