Deprecate openssl (#281)

Replace openssl with rust native libraries Addresses #274.
mihai-dinculescu · Oct 20, 2024 · c5c28c4 · c5c28c4
1 parent 79a4075
commit c5c28c4
Show file tree

Hide file tree

Showing 9 changed files with 467 additions and 528 deletions.
diff --git a/.cargo/audit.toml b/.cargo/audit.toml
@@ -0,0 +1,5 @@
+[advisories]
+ignore = [
+    # The Marvin Attack poses minimal risk to the use cases of this library
+    "RUSTSEC-2023-0071",
+]
diff --git a/.github/workflows/py-ci.yml b/.github/workflows/py-ci.yml
@@ -44,21 +44,7 @@ jobs:
         uses: PyO3/maturin-action@v1
         with:
           target: ${{ matrix.platform.target }}
-          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml --features openssl-vendored
-          before-script-linux: |
-            # If we're running on rhel centos, install needed packages.
-            if command -v yum &> /dev/null; then
-                yum update -y && yum install -y perl-core openssl openssl-devel pkgconfig libatomic
-
-                # If we're running on i686 we need to symlink libatomic
-                # in order to build openssl with -latomic flag.
-                if [[ ! -d "/usr/lib64" ]]; then
-                    ln -s /usr/lib/libatomic.so.1 /usr/lib/libatomic.so
-                fi
-            else
-                # If we're running on debian-based system.
-                apt update -y && apt-get install -y libssl-dev openssl pkg-config
-            fi
+          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml
           sccache: "true"
           manylinux: auto
       - name: Upload wheels
@@ -89,7 +75,7 @@ jobs:
         uses: PyO3/maturin-action@v1
         with:
           target: ${{ matrix.platform.target }}
-          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml --features openssl-vendored
+          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml
           sccache: "true"
           manylinux: musllinux_1_2
       - name: Upload wheels
@@ -117,7 +103,7 @@ jobs:
         uses: PyO3/maturin-action@v1
         with:
           target: ${{ matrix.platform.target }}
-          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml --features openssl-vendored
+          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml
           sccache: "true"
       - name: Upload wheels
         uses: actions/upload-artifact@v4
@@ -143,7 +129,7 @@ jobs:
         uses: PyO3/maturin-action@v1
         with:
           target: ${{ matrix.platform.target }}
-          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml --features openssl-vendored
+          args: --release --out dist --find-interpreter --manifest-path ./tapo-py/Cargo.toml
           sccache: "true"
       - name: Upload wheels
         uses: actions/upload-artifact@v4

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,8 +10,16 @@ file. This change log follows the conventions of
 
 - Added support for the P304 power strip.
 
+### Changed
+
+- The `openssl` dependency has been replaced with native Rust alternatives to expand cross-compilation options, such as for Android, and to decrease build times.
+
 ## [Python Unreleased][Unreleased]
 
+### Changed
+
+- The `openssl` dependency has been replaced with native Rust alternatives to expand cross-compilation options, such as for Android, and to decrease build times.
+
 ## [Rust v0.7.16][v0.7.16] - 2024-09-27
 
 ### Added