You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I get pretty consistent printout of the folowing traceback every time there is a server restart. This should have been handled in asyncio_redis_manager.py as an additional exception which simply stops listening (by terminating the infinite loop there). Unless there is a different graceful shutdown pathway I'm not considering.
To Reproduce
Steps to reproduce the behavior:
Setup python-socketio with aiohttp deployment strategy
run server
stop server
Expected behavior
I wouldn't expect this to be thrown as an issue at all. We know the server is shutting down, and ultimately cancelling all asyncio tasks related to the current loop.
Logs
Traceback (most recent call last):
File ".venv/lib/python3.8/site-packages/socketio/asyncio_pubsub_manager.py", line 152, in _thread
message = await self._listen()
File ".venv/lib/python3.8/site-packages/socketio/asyncio_redis_manager.py", line 98, in _listen
return await self.ch.get()
File ".venv/lib/python3.8/site-packages/aioredis/pubsub.py", line 73, in get
msg = await self._queue.get()
File ".venv/lib/python3.8/site-packages/aioredis/pubsub.py", line 416, in get
await self.wait()
File ".venv/lib/python3.8/site-packages/aioredis/pubsub.py", line 412, in wait
await self._event.wait()
File "/usr/lib/python3.8/asyncio/locks.py", line 309, in wait
await fut
asyncio.exceptions.CancelledError
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Describe the bug
I get pretty consistent printout of the folowing traceback every time there is a server restart. This should have been handled in asyncio_redis_manager.py as an additional exception which simply stops listening (by terminating the infinite loop there). Unless there is a different graceful shutdown pathway I'm not considering.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I wouldn't expect this to be thrown as an issue at all. We know the server is shutting down, and ultimately cancelling all asyncio tasks related to the current loop.
Logs
Traceback (most recent call last):
File ".venv/lib/python3.8/site-packages/socketio/asyncio_pubsub_manager.py", line 152, in _thread
message = await self._listen()
File ".venv/lib/python3.8/site-packages/socketio/asyncio_redis_manager.py", line 98, in _listen
return await self.ch.get()
File ".venv/lib/python3.8/site-packages/aioredis/pubsub.py", line 73, in get
msg = await self._queue.get()
File ".venv/lib/python3.8/site-packages/aioredis/pubsub.py", line 416, in get
await self.wait()
File ".venv/lib/python3.8/site-packages/aioredis/pubsub.py", line 412, in wait
await self._event.wait()
File "/usr/lib/python3.8/asyncio/locks.py", line 309, in wait
await fut
asyncio.exceptions.CancelledError
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: