-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some upstream standard rules are not properly propagated to their @typescript-eslint version #582
Comments
It seems |
@rsdmike, camelcase isn't part of the TypeScript ESLint rules. It's equivalent is naming-convention. |
By the way, @rostislav-simonik and I are currently working on this. |
@mightyiam, I've got a much more complete form of my original PR's intension in scalecore/eslint-config-scalecore which handles propagation, conversion, and exclusion of rules enabled by eslint-config-standard, or any other configuration. |
@6XGate I have a feeling that @rostislav-simonik and I doing this ourselves would end up being an effort similar to reading your code and trying to adapt it to our purpose. Or perhaps less of an effort, due to reduced context in comparison. Another option is for you to join us in our mob programming sessions. Three is a real mob. |
I could try tackling that Monday after I'm back home. |
I just pushed an update to the #583 pull request that should propagate all rules |
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens, no-loss-of-precision, object-curly-spacing, space-before-blocks, comma-dangle. Closes #582, closes #583. Co-authored-by: Rostislav Simonik <[email protected]>
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens, no-loss-of-precision, object-curly-spacing, space-before-blocks, comma-dangle. Closes #582, closes #583. Co-authored-by: Rostislav Simonik <[email protected]>
BREAKING CHANGE: add rules from @typescript-eslint: no-extra-parens, no-loss-of-precision, object-curly-spacing, space-before-blocks, comma-dangle. Closes #582, closes #583. Co-authored-by: Rostislav Simonik <[email protected]>
## [23.0.0](v22.0.0...v23.0.0) (2022-09-13) ### ⚠ BREAKING CHANGES * add rules from @typescript-eslint: no-extra-parens, no-loss-of-precision, object-curly-spacing, space-before-blocks, comma-dangle. ### Features * use all typescript-eslint equivalents ([1e8764d](1e8764d)), closes [#582](#582) [#583](#583) ### CI * continuous delivery ([971c680](971c680)), closes [#840](#840) ### Build system / dependencies * renovate automergeMinor github actions ([02dde9d](02dde9d)), closes [#910](#910)
What version of this package are you using?
20.0.0
What operating system, Node.js, and npm version?
node v12.22.1
npm v7.14.0
What happened?
The following rules are defined in the upstream standard configuration but not propagated to their
@typescript-eslint
equivalents.comma-dangle
no-loss-of-precision
no-implied-eval
no-loss-of-precision
object-curly-spacing
space-infix-ops
What did you expect to happen?
That the listed rules would be propagated to their TypeScript version and disabled.
Are you willing to submit a pull request to fix this bug?
maybe
The text was updated successfully, but these errors were encountered: