Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to winget #1279

Closed
4 tasks done
Cyberavater opened this issue Aug 25, 2022 · 11 comments
Closed
4 tasks done

Add to winget #1279

Cyberavater opened this issue Aug 25, 2022 · 11 comments

Comments

@Cyberavater
Copy link

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Description

Hello, can you add this package to winget?

I've already opened an issue there, they're asking to sign the appx file.

microsoft/winget-pkgs#72074 (comment)

@mifi
Copy link
Owner

mifi commented Aug 25, 2022

Unfortunately I'm not going to work on signing the appx file, but if someone wants to submit a PR, you're welcome to do that. For more info see #337

@mifi mifi closed this as completed Aug 25, 2022
@asilentdreamer
Copy link

I believe this issue should be re-opened as winget now supports installing portable apps that are distributed as an archive. Unfortunately it only supports zip archives right now and lossless cut is only distributed as 7z on windows.

@asilentdreamer
Copy link

Hi @mifi, pinging you since I am not sure whether people get notified for comments on closed issues. Sorry if you did.

@mifi
Copy link
Owner

mifi commented Aug 13, 2024

hmm, can zipped unsigned exe files be added to winget? if so, then maybe we could add a post-build script to convert the 7z to zip and then auto upload it to winget. though it's not a priority for me to implement unfortunately.

@asilentdreamer
Copy link

Yes, winget doesn't have any issue with unsigned exes. It would be pretty easy to set it up using https://github.com/vedantmgoyal9/winget-releaser once there is a zip file in releases. But yeah, I understand that this is a low priority issue.

@mifi
Copy link
Owner

mifi commented Aug 15, 2024

so is this comment incorrect? microsoft/winget-pkgs#72074 (comment)

@asilentdreamer
Copy link

asilentdreamer commented Aug 15, 2024

When that comment was made 2 years ago, winget didn't support zip files or portable apps. Now it does and can install apps from a zip archive or standalone exes just like scoop does.

So you don't need to bother with appx now but that comment is accurate. To my knowledge if you use an appx file , it does need to be signed. But if you use any other type of file (installer, standalone exe, zip archive), it doesn't need to be signed.

@mifi
Copy link
Owner

mifi commented Aug 15, 2024

ok, thanks for clarifying

@pyorot
Copy link

pyorot commented Oct 8, 2024

Yes, winget doesn't have any issue with unsigned exes. It would be pretty easy to set it up using https://github.com/vedantmgoyal9/winget-releaser once there is a zip file in releases. But yeah, I understand that this is a low priority issue.

i dunno if i would consider this low-priority; at this point, winget is fairly mature and often used for routine updating. losslesscut isn’t something people often think to update so it can kind of chill for 4 years before it being outdated is noticed, i find. there’s now an “update available” notification but without an installer, it’s painful to update cos of user privilege in the program files directory in windows

all together, this basically means the current setup is a good way to have users miss out on new features

@mifi
Copy link
Owner

mifi commented Oct 9, 2024

Personally I don't have any incentive to publish and maintain a separate winget version of losslesscut. If people want auto updates and support my work, they can get get it from the MS Store (which I do maintain). Because the github version of losslesscut will notify people if it's outdated, I think it's gonna be hard for people to not notice after 4 years. if they don't want to upgrade, that's also fine. So to summarize: maintaining a winget package adds extra work for me, and it's a slippery slope, because once I accept one such request, there will surely be more requests. However if anyone else wants to do the work+maintenance and package losslesscut and publish it on winget, that is totally fine with me (it's GPLv2 after all). Just like someone (not me) published it on chocolatey and flathub. see also FAQ

@pyorot
Copy link

pyorot commented Oct 17, 2024

I think after researching winget some more, your position makes more sense. It moves like abandonware despite being only 4 years old. In my mind, winget should fill the niche of being the default OS-provided method for managing packages semi-automatically, similarly to apt in Linux, since it's first-party and based on the same design. If that were the case then I'd have more of a qualm with intentionally not supporting it to funnel money towards MS Store and I'd suggest something more akin to the "license" model I've seen with immich for example. Having to manually download installers is terrible but I think given the state of winget, the future is not yet now. Thanks for the explanation 🙇‍♂️.

You're probably right about it being hard to not notice a new version, but my 4-year-old version didn't have an update-available alert built into it haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants