Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature number-count animation for DORA-cards #610

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

xyfer17
Copy link
Contributor

@xyfer17 xyfer17 commented Oct 23, 2024

Linked Issue(s)

#385

Acceptance Criteria fulfillment

  • Task 1
  • Task 2
  • Task 3

Proposed changes (including videos or screenshots)

Screen.Recording.2024-10-23.161511.mp4

Further comments

As per issue #385 , have Implement a number-count animation for DORA-cards using custom hook logic.

@jayantbh
Copy link
Contributor

You can undo the axios change. Please rebase onto main.

@xyfer17
Copy link
Contributor Author

xyfer17 commented Oct 23, 2024

You can undo the axios change. Please rebase onto main.

done, pushed

Copy link
Contributor

@jayantbh jayantbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 95% done. Nice work!

@xyfer17 xyfer17 requested a review from jayantbh October 28, 2024 13:51
@jayantbh jayantbh merged commit e625e8e into middlewarehq:main Oct 30, 2024
2 of 3 checks passed
@xyfer17 xyfer17 deleted the feature/countup-animation branch October 31, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants