-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature number-count animation for DORA-cards #610
Merged
jayantbh
merged 6 commits into
middlewarehq:main
from
xyfer17:feature/countup-animation
Oct 30, 2024
Merged
Feature number-count animation for DORA-cards #610
jayantbh
merged 6 commits into
middlewarehq:main
from
xyfer17:feature/countup-animation
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
You can undo the axios change. Please rebase onto main. |
done, pushed |
jayantbh
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 95% done. Nice work!
web-server/src/content/DoraMetrics/DoraCards/WeeklyDeliveryVolumeCard.tsx
Outdated
Show resolved
Hide resolved
web-server/src/content/DoraMetrics/DoraCards/MeanTimeToRestoreCard.tsx
Outdated
Show resolved
Hide resolved
web-server/src/content/DoraMetrics/DoraCards/ChangeFailureRateCard.tsx
Outdated
Show resolved
Hide resolved
jayantbh
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue(s)
#385
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Screen.Recording.2024-10-23.161511.mp4
Further comments
As per issue #385 , have Implement a number-count animation for DORA-cards using custom hook logic.