Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Notification models are missing #95

Closed
Tracked by #1
nshttpd opened this issue Jun 8, 2022 · 2 comments
Closed
Tracked by #1

Change Notification models are missing #95

nshttpd opened this issue Jun 8, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request Standard GitHub label Issue caused by core project dependency modules or library
Milestone

Comments

@nshttpd
Copy link

nshttpd commented Jun 8, 2022

The Java SDK has models for ChangeNotification and ChangeNotificationCollection to Unmarshal into when handling webhook notifications from Subscriptions, but these and other associated models seem to be missing from the Go SDK.

Is this possibly because of how the Go SDK is autogenerated that these are missing because they are not part of an API Request, but on the receiving end of data?

@ghost ghost added the needs triage 🔍 label Jun 8, 2022
@baywet baywet transferred this issue from microsoftgraph/msgraph-sdk-go Jun 9, 2022
@baywet baywet self-assigned this Jun 9, 2022
@baywet baywet added enhancement New feature or request Standard GitHub label Issue caused by core project dependency modules or library and removed needs triage 🔍 labels Jun 9, 2022
@baywet baywet mentioned this issue Jun 9, 2022
25 tasks
@baywet
Copy link
Member

baywet commented Jun 9, 2022

Hi @nshttpd
Thanks for reaching out and for trying the Go SDK.

You're absolutely right, these models are missing because they are not referenced by any API in the API description. And by design kiota, our next generation SDK generator, only generates the models as they are needed.

The easiest way to get those models would probably be to:

  1. Take the existing OpenAPI description
  2. Add a placeholder path item that returns change notifications
  3. Clear any other endpoint
  4. Use Kiota to generate the models
  5. Place the models in this core library under a models package (so they can also be used in beta)

Do you think this is something you'd be willing to submit a pull request for?

@rkodev
Copy link
Contributor

rkodev commented Feb 8, 2023

Going to close this issue as change Notifications models are currently available in v0.54 https://github.com/microsoftgraph/msgraph-sdk-go/blob/main/models/change_notification.go

@rkodev rkodev closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Standard GitHub label Issue caused by core project dependency modules or library
Projects
None yet
Development

No branches or pull requests

4 participants