From 30f251383c445afd821c9072d29006f26f544ae1 Mon Sep 17 00:00:00 2001
From: ezkemboi <ezrqnkemboi@gmail.com>
Date: Sat, 14 Nov 2020 16:03:26 +0300
Subject: [PATCH 1/3] descriptive message after pop-up blocked in browser

---
 src/app/views/authentication/Authentication.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app/views/authentication/Authentication.tsx b/src/app/views/authentication/Authentication.tsx
index 9a6e72769..7926dfea4 100644
--- a/src/app/views/authentication/Authentication.tsx
+++ b/src/app/views/authentication/Authentication.tsx
@@ -38,7 +38,7 @@ export class Authentication extends Component<IAuthenticationProps, { loginInPro
       this.props.actions!.setQueryResponseStatus({
         ok: false,
         statusText: messages['Authentication failed'],
-        status: errorCode.replace('_', ' '),
+        status: errorCode === 'popup_window_error' ? 'popup blocked, allow pop-up windows in your browser' : errorCode.replace('_', ' '),
         messageType: MessageBarType.error
       });
       this.setState({ loginInProgress: false });

From c73085996ad1bde4f0da8e30f2ea0a078c087fda Mon Sep 17 00:00:00 2001
From: ezkemboi <ezrqnkemboi@gmail.com>
Date: Sat, 14 Nov 2020 16:13:23 +0300
Subject: [PATCH 2/3] fix lint

---
 src/app/views/authentication/Authentication.tsx | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/app/views/authentication/Authentication.tsx b/src/app/views/authentication/Authentication.tsx
index 7926dfea4..09769fc27 100644
--- a/src/app/views/authentication/Authentication.tsx
+++ b/src/app/views/authentication/Authentication.tsx
@@ -38,7 +38,9 @@ export class Authentication extends Component<IAuthenticationProps, { loginInPro
       this.props.actions!.setQueryResponseStatus({
         ok: false,
         statusText: messages['Authentication failed'],
-        status: errorCode === 'popup_window_error' ? 'popup blocked, allow pop-up windows in your browser' : errorCode.replace('_', ' '),
+        status: errorCode === 'popup_window_error'
+          ? 'popup blocked, allow pop-up windows in your browser'
+          : errorCode.replace('_', ' '),
         messageType: MessageBarType.error
       });
       this.setState({ loginInProgress: false });

From bae8d3634dd6bbb0a689fbc9b74b14d8f6a45c42 Mon Sep 17 00:00:00 2001
From: ezkemboi <ezrqnkemboi@gmail.com>
Date: Mon, 16 Nov 2020 19:57:07 +0300
Subject: [PATCH 3/3] add message translation

---
 src/app/views/authentication/Authentication.tsx | 3 ++-
 src/messages/GE.json                            | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/app/views/authentication/Authentication.tsx b/src/app/views/authentication/Authentication.tsx
index 09769fc27..a85e46ed1 100644
--- a/src/app/views/authentication/Authentication.tsx
+++ b/src/app/views/authentication/Authentication.tsx
@@ -9,6 +9,7 @@ import { Mode } from '../../../types/enums';
 import * as authActionCreators from '../../services/actions/auth-action-creators';
 import * as queryStatusActionCreators from '../../services/actions/query-status-action-creator';
 import { logIn } from '../../services/graph-client/msal-service';
+import { translateMessage } from '../../utils/translate-messages';
 import { classNames } from '../classnames';
 import { showSignInButtonOrProfile } from './auth-util-components';
 import { authenticationStyles } from './Authentication.styles';
@@ -39,7 +40,7 @@ export class Authentication extends Component<IAuthenticationProps, { loginInPro
         ok: false,
         statusText: messages['Authentication failed'],
         status: errorCode === 'popup_window_error'
-          ? 'popup blocked, allow pop-up windows in your browser'
+          ? translateMessage('popup blocked, allow pop-up windows in your browser')
           : errorCode.replace('_', ' '),
         messageType: MessageBarType.error
       });
diff --git a/src/messages/GE.json b/src/messages/GE.json
index 4d574713d..0295c395d 100644
--- a/src/messages/GE.json
+++ b/src/messages/GE.json
@@ -323,5 +323,6 @@
   "Get token details (Powered by jwt.ms)": "Get token details (Powered by jwt.ms)",
   "HTTP request method option": "HTTP request method option",
   "Microsoft Graph API Version option": "Microsoft Graph API Version option",
-  "Query Sample Input": "Query sample input"
+  "Query Sample Input": "Query sample input",
+  "popup blocked, allow pop-up windows in your browser": "popup blocked, allow pop-up windows in your browser"
 }
\ No newline at end of file