Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credscan to Azure pipelines #592

Closed
MIchaelMainer opened this issue Jun 25, 2020 · 0 comments · Fixed by #937
Closed

Add credscan to Azure pipelines #592

MIchaelMainer opened this issue Jun 25, 2020 · 0 comments · Fixed by #937
Labels
promote type:security Security, or privacy issue
Milestone

Comments

@MIchaelMainer
Copy link
Contributor

MIchaelMainer commented Jun 25, 2020

Is your feature request related to a problem? Please describe.

All repos should run credscan task to make sure we are not checking in credentials.
https://github.com/microsoftgraph/microsoft-graph-explorer-v4/blob/dev/azure-pipelines.yml

Describe the solution you'd like

- task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@2
  displayName: 'Run CredScan'
  inputs:
    debugMode: false

We will likely have to add a suppression file since we have samples that have password in them.

Additional context
This addresses OXO4007424.

AB#7510

@Shjokie Shjokie added the dependency:security-review Issue that has dependency on security or privacy review label Jun 26, 2020
@ddyett ddyett added the promote label Jan 11, 2021
@thewahome thewahome linked a pull request Jun 8, 2021 that will close this issue
@thewahome thewahome added this to the June 2021 milestone Jun 16, 2021
@adhiambovivian adhiambovivian added type:security Security, or privacy issue and removed dependency:security-review Issue that has dependency on security or privacy review labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promote type:security Security, or privacy issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants