Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clone the resources and re-assign children to found values #3337

Merged
merged 7 commits into from
Sep 27, 2024
Merged

fix: clone the resources and re-assign children to found values #3337

merged 7 commits into from
Sep 27, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Sep 25, 2024

Overview

Use Object.assign to clone the resources object and re-assign the .children to the found resources.

Closes #3335

@musale musale requested a review from a team as a code owner September 25, 2024 09:36
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3337.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3337.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3337.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3337.centralus.azurestaticapps.net

@musale @Mnickii
Prettier fixes
1b74c2a 
Co-authored-by: Nickii Miaro <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3337.centralus.azurestaticapps.net

@musale musale merged commit 974c3bc into dev Sep 27, 2024
20 checks passed
@musale musale deleted the fix/resources-search branch September 27, 2024 08:37
@release-please release-please bot mentioned this pull request Sep 27, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@musale musale linked an issue Sep 27, 2024 that may be closed by this pull request
Graph explorer UI crashes when searching resources #3331
Closed
@release-please release-please bot mentioned this pull request Oct 2, 2024
Merged
@ElinorW ElinorW mentioned this pull request Oct 7, 2024
Merged
ElinorW added a commit that referenced this pull request Oct 7, 2024
@ElinorW
Chore: Release 10.4.1 (#3384)
b5e08be 
* Chore: September dependabot upgrades (#3324)

* Fix: Inputting beta version results in getting beta endpoint suggestions (#3289)

* chore: bootstrap release please to the dev branch (#3340)

* fix: clone the resources and re-assign children to found values (#3337)

* chore: add starting commit where changelog commits gathering will stop (#3345)

* Fix: Dependency security patch updates  (#3355)

* chore: migrate releases to governed templates (#3377)

* Fix: Update playwright tests (#3381)

* chore: Remove reference to a deprecated rule (#3380)

* chore(dev): release 10.4.1 (#3376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnickii Mnickii Mnickii left review comments

@ElinorW ElinorW ElinorW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph Explorer Resources not working properly Graph explorer UI crashes when searching resources
3 participants
@musale @Mnickii @ElinorW