Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adaptive cards and toolkit heights #2734

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Aug 9, 2023

Overview

#2703

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
    Click on the toolkit tab. Notice that the height is okay
    Click on the Run query button to run /me
    Click on the Adaptive cards tab and check that JSON tab height is okay

@Onokaev Onokaev requested a review from a team as a code owner August 9, 2023 13:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Onokaev Onokaev merged commit 17aceb6 into dev Aug 15, 2023
@Onokaev Onokaev deleted the fix/adaptive-cards-json-editor branch August 15, 2023 11:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants