Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Set consent-type property #2465

Merged
merged 12 commits into from
Apr 4, 2023
Merged

Fix: Set consent-type property #2465

merged 12 commits into from
Apr 4, 2023

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Mar 23, 2023 •
edited
Loading

Overview

Fixes #2439

Demo

image
A spinner becomes available when the consent-type property is being fetched

When the fetch fails, a retry button is available to re-fetch the consent-type property
image

Notes

The API call that returns the grants of the tenant takes time to return an updated grant after granting consent. For this reason, we have to poll the endpoint until we have an update.

The identity endpoints read data from eventually consistent datastores. This means that after updating a field, it takes time for all nodes to achieve the same state(eventual consistency). This means that calling the endpoint for updated data might still return stale data even after a write.
For this reason, we have to keep polling the endpoint until we get the response that we expect. This is why we have a loop that continuously calls the grant endpoint until we have an updated grant.

Testing Instructions

  • How to test this PR
    Sign in with your account
    Notice that all consent-type properties are available for consented permissions
    Consent to a permission and notice the spinner just before the consent-type property is updated
    Click on the retry button to re-fetch the consent-type property

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

@Onokaev Onokaev marked this pull request as ready for review March 23, 2023 11:11
@Onokaev Onokaev requested a review from ElinorW March 27, 2023 06:33
@Onokaev Onokaev assigned thewahome and unassigned thewahome Mar 27, 2023
@Onokaev Onokaev requested a review from thewahome March 27, 2023 06:33
@microsoftgraph microsoftgraph deleted a comment from sonarqubecloud bot Mar 27, 2023
@microsoftgraph microsoftgraph deleted a comment from github-actions bot Mar 27, 2023
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

@Onokaev Onokaev requested a review from ElinorW April 3, 2023 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2465.centralus.azurestaticapps.net

@Onokaev Onokaev merged commit 2be02cf into dev Apr 4, 2023
@Onokaev Onokaev deleted the fix/set-consenttype-property branch April 4, 2023 14:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

This was referenced Sep 25, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

@ElinorW ElinorW Awaiting requested review from ElinorW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permissions - consent type not showing up
3 participants
@Onokaev @ElinorW @thewahome