Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Suspending letters get cut off #2459

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix: Suspending letters get cut off #2459

merged 1 commit into from
Mar 22, 2023

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented Mar 21, 2023

Overview

Fixes #2460 : Letters that are supposed to suspend ('g', 'p', 'y') are getting cut off.

Demo

Before:
image

After
image

Notes

Added a padding to the bottom of the title

@thewahome thewahome requested a review from ElinorW March 21, 2023 11:53
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2459.centralus.azurestaticapps.net

@thewahome thewahome merged commit 40a7bda into dev Mar 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome deleted the fix/letters-get-cut-off branch May 3, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Letters that suspend are being cut off
2 participants