Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable code selection in Expand view #2435

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Mar 6, 2023

Overview

Closes #2420

Demo

image

Notes

The issue was due to React 17 upgrade, this affected how events are controlled and fluentUI mentions this in the docs.
Ref: https://developer.microsoft.com/en-us/fluentui#/controls/web/layer#ILayerProps

Testing Instructions

  • Checkout branch
  • Run GET my profile query
  • Select Expand Tab
  • Try to select/highlight the code on the tab

@ElinorW ElinorW requested review from Onokaev and thewahome March 6, 2023 14:13
@ElinorW ElinorW merged commit 4cf2018 into dev Mar 6, 2023
@ElinorW ElinorW deleted the fix/expand-selection branch March 6, 2023 14:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome mentioned this pull request Mar 10, 2023
thewahome added a commit that referenced this pull request Mar 13, 2023
Add a devcontainer to the repo (#2421)
Task: Add copy telemetry (#2419)
Fix: Enable code selection in Expand view (#2435)
Chore(deps): Bump loader-utils from 2.0.2 to 2.0.4 (#2433)
Chore(deps): Bump json5 from 1.0.1 to 1.0.2 (#2434)
Task: Handle claims challenge (#2422)
Fix: Update azure-pipelines.yml for Azure Pipelines (#2444)
Fix: Autocomplete filter (#2432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select/highlight code on Expanded view
2 participants