Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query url not sanitized when sharing query #1838

Closed
Onokaev opened this issue Jun 14, 2022 · 0 comments · Fixed by #1842
Closed

Query url not sanitized when sharing query #1838

Onokaev opened this issue Jun 14, 2022 · 0 comments · Fixed by #1842
Assignees
Milestone

Comments

@Onokaev
Copy link
Contributor

Onokaev commented Jun 14, 2022

Describe the bug
When sharing a query after clicking the share query button, the url shown in the textbox contains id information (if the url had ids)

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Add a query that requires any ids to the query url and supply any dummy id
  3. Click on the share query button
  4. Notice that the url to be shared has an id within it

Expected behavior
All ids should be redacted before populating the share query textbox

Screenshots
image

@Onokaev Onokaev added this to the June-2022 milestone Jun 14, 2022
@ghost ghost added the ToTriage label Jun 14, 2022
@Onokaev Onokaev self-assigned this Jun 16, 2022
@ghost ghost removed the ToTriage label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant