Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up autocomplete suggestions #1465

Closed
thewahome opened this issue Feb 17, 2022 · 3 comments · Fixed by #1802
Closed

Speed up autocomplete suggestions #1465

thewahome opened this issue Feb 17, 2022 · 3 comments · Fixed by #1802
Assignees
Labels
Area: Autocomplete type:infrastructure Core back-end work which includes quality work, code refactor, tests etc
Milestone

Comments

@thewahome
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
For the resource explorer to work, the application fetches a links only subset of the open-API description. We can leverage this since it is local and can reduce the calls made to the api

Describe the solution you'd like
Only check the API for query parameters since they do not come in with the open-API description loaded on page load. Since the links are already available, simply check in state to get the next part of the url. e.g. me/ should yield a list straight from the state and not from a network call

Describe alternatives you've considered
Keeping it as is. No complaints have been made so far about the number of network calls

Additional context
Reducing network dependency would make autocomplete search faster

@ghost ghost added the ToTriage label Feb 17, 2022
@thewahome thewahome added Area: Autocomplete type:infrastructure Core back-end work which includes quality work, code refactor, tests etc labels Feb 17, 2022
@thewahome
Copy link
Collaborator Author

This implementation would change the endpoint from autocomplete to openapitree . Closing it as it limits the functionalities we can receive from the autocomplete endpoint

@adhiambovivian
Copy link

@thewahome what's our current autocomplete performance and what's our target baseline performance?

@adhiambovivian adhiambovivian added this to the June-2022 milestone May 31, 2022
@thewahome
Copy link
Collaborator Author

I've seen calls take 400ms. With this method we can get them down to 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Autocomplete type:infrastructure Core back-end work which includes quality work, code refactor, tests etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants