Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Ensure Graph Explorer is responsive on common screen sizes #1412

Closed
5 tasks done
Tracked by #1416
RabebOthmani opened this issue Feb 3, 2022 · 9 comments
Closed
5 tasks done
Tracked by #1416
Assignees
Labels
priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs type:user-experience An issue related to user experience mainly ui/ux
Milestone

Comments

@RabebOthmani
Copy link

RabebOthmani commented Feb 3, 2022

As a user, I want an optimal UI experience no matter what device I'm using
So I can fully take advantage of the tool and focus on my learning experience

Acceptance Criteria

Design Resources

@RabebOthmani RabebOthmani added UI Polish type:user-experience An issue related to user experience mainly ui/ux labels Feb 3, 2022
@RabebOthmani RabebOthmani added this to the Feb 04 - Mar 03 milestone Feb 4, 2022
@ElinorW ElinorW self-assigned this Feb 7, 2022
@ElinorW
Copy link
Contributor

ElinorW commented Feb 21, 2022

  • Common devices used include: phones, tablets, laptops and desktop monitors.

  • Screen sizes according to this would be:
    : 1920px for very large screens
    : 1366px - 1919px for extra extra large screens
    : 1024px - 1365px for extra large screens
    : 640px - 1023px for large screens
    : 480px - 639px - for medium screens

  • We use bootstrap which already comes with the a set stylesheet covering all responsive scenarios.

My idea was to ensure everything is wrapped in bootstrap containers/row/columns so that was we don't have to individually configure each component on the screen.
From my observations, with the work that was done on resizing, the containers/rows/columns have already been put in place.

@ElinorW
Copy link
Contributor

ElinorW commented Feb 23, 2022

A screenshot to support this
image
The full page is contained in the bootstrap container that comes with a grid stylesheet

@RabebOthmani
Copy link
Author

Hi @ElinorW @thewahome , I'll leave it to you to make the technical decision. Here are some of the things I saw that led me to assume it is maybe related to responsiveness.
For example, the permission tab is not rendering properly and behaves differently between Edge and Chrome on the same machine. (cc @Onokaev )
The pane that contains the response, code snippets etc is not showing me all tabs on a 15" screen which is a very common screen . Also when you start zooming in/out, scrolling and expanding panes, a lot of the elements on the screen won't render properly (text boxes, button, etc)
permissions on chrome
permissions on edge
resize

feedback on zoom

@RabebOthmani RabebOthmani added the priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs label Feb 28, 2022
@ElinorW
Copy link
Contributor

ElinorW commented Mar 2, 2022

Hey @RabebOthmani,
Thank you for pointing some of these issues out.
Regarding the permissions, from the shared screenshot, is the difference you are pointing out to do with the added column? The status column appears when a user is signed in and this affects the message displayed under the Permissions as well.

The tabs get folded in when there isn't enough space for it. This is actually a responsive feature introduced by Fluent UI.

I'm not to clear on the last screenshot, could you explain a little more about what is expected?

@adhiambovivian
Copy link

@RabebOthmani we need to define responsive design baseline requirements to guide the implementation details:

  • Browser experience: Browser target baselines
  • If GE should be responsive on tablet/ mobile view
  • Responsiveness for different screen sizes, resolutions, different browsers, & Zoom in & Zoom out support

@RabebOthmani
Copy link
Author

@adhiambovivian I've already started the conversation with the UX team. I'll work with Lisa on this and provide the team with more details

@RabebOthmani
Copy link
Author

The recommendation from the UX team is to use 1873W x 947H
More details here https://gs.statcounter.com/screen-resolution-stats

@gavinbarron
Copy link
Member

@RabebOthmani @adhiambovivian @ElinorW this is a great discussion to be having and an area that we can improve on.
One thing that can make responsive design even more challenging is that Windows will set a default zoom level on high resolution screens that can cause your screen to render the page as though it were much smaller.
e.g.
image
Causes the GE page to render on my screen as though it were only ~1200px wide:
image

Given this it's really important that we ensure that we look at the effective resolution when raising this kind of issue.

@ElinorW ElinorW added the Responsive design Related to responsiveness label Aug 4, 2022
@Onokaev Onokaev modified the milestones: Parked, January 2023 Jan 10, 2023
@darrelmiller darrelmiller removed this from the January 2023 milestone Feb 6, 2023
@darrelmiller darrelmiller added this to the Feb-2023 milestone Feb 6, 2023
@ElinorW ElinorW modified the milestones: Feb-2023 , March-2023 Mar 8, 2023
@ElinorW
Copy link
Contributor

ElinorW commented Mar 20, 2023

This is completed now

@ElinorW ElinorW closed this as completed Mar 20, 2023
@adhiambovivian adhiambovivian removed UI Polish Responsive design Related to responsiveness labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs type:user-experience An issue related to user experience mainly ui/ux
Projects
None yet
Development

No branches or pull requests

6 participants