Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some RequestBuilder interfaces don't implement common IBaseRequestBuilder #266

Closed
michael-hawker opened this issue Jun 25, 2020 · 2 comments
Closed

Some RequestBuilder interfaces don't implement common IBaseRequestBuilder #266

michael-hawker opened this issue Jun 25, 2020 · 2 comments
Assignees
@MIchaelMainer
Labels
promote

Comments

@michael-hawker
Copy link

michael-hawker commented Jun 25, 2020 •
edited by azure-boards bot
Loading

Describe the bug
See microsoftgraph/msgraph-sdk-dotnet-core#124 for details.

For instance IDriveRecentRequestBuilder is not a IBaseRequestBuilder even though its implementation could be:

https://github.com/microsoftgraph/msgraph-sdk-dotnet/blob/9b74c2674969008669e4c46ac85bda7e6ad8a728/src/Microsoft.Graph/Requests/Generated/IDriveRecentRequestBuilder.cs#L19

This makes it hard for us to accept a general builder as part of a helper API to make general calls to the graph in the Windows Community Toolkit Graph Control library

Expected behavior
All generated interfaces compatible with IBaseRequestBuilder should implement that interface as well as a base. This should be trivial as I believe the concrete implementations should all provide the pattern, so this should just about the generator adding the inheritance to the base interface.

AB#5125
@MIchaelMainer MIchaelMainer self-assigned this Jun 25, 2020
@MIchaelMainer
Copy link
Contributor

Actually, I think this is a requirement if we are to support composable functions.

@MIchaelMainer MIchaelMainer transferred this issue from microsoftgraph/msgraph-sdk-dotnet Jul 28, 2020
@ghost ghost added the ToTriage label Jul 28, 2020
@ghost ghost removed the ToTriage label Aug 3, 2020
This was referenced Aug 6, 2020
Merged
Closed
@michael-hawker michael-hawker mentioned this issue Nov 17, 2020
Closed
9 tasks
@ddyett ddyett added the promote label Jan 11, 2021
@MIchaelMainer
Copy link
Contributor

This work was added with composable functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MIchaelMainer MIchaelMainer

Labels
promote
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MIchaelMainer @ddyett @michael-hawker