Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: HandBrake.HandBrake 1.6.0 arm64 -> 404 #93950

Open
2 tasks done
donid opened this issue Jan 17, 2023 · 2 comments
Open
2 tasks done

[Package Issue]: HandBrake.HandBrake 1.6.0 arm64 -> 404 #93950

donid opened this issue Jan 17, 2023 · 2 comments
Labels
Help-Wanted This is a good candidate work item from the community.

Comments

@donid
Copy link
Contributor

donid commented Jan 17, 2023

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

The URL of the 'arm64' arch points to https://github.com/HandBrake/HandBrake/releases/download/1.6.0/HandBrake-1.6.0-arm64-Win_GUI.exe which yields a 404 not found error.
The HandBrake team apparently has moved from using 'arm64' to 'aarch64' as tag. But the 1.6.0 release does not contain an asset with either name for the HandBrake GUI (an aarch64_CLI asset exists).
This raises another question: why didn't the automated checks during the winget package submission process not detect that error?

Steps to reproduce

browse to the given URL

Actual behavior

error 404

Expected behavior

  • fix the URL or remove the arch from the package
  • maybe improve the automated checks during package submission

Environment

not relevant

Screenshots and Logs

No response

@donid donid added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jan 17, 2023
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 17, 2023
@stephengillie stephengillie added Help-Wanted This is a good candidate work item from the community. and removed Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage This work item needs to be triaged by a member of the core team. labels Jan 17, 2023
@mdanish-kh
Copy link
Contributor

All Urls are passed through the CI pipelines to ensure they are not 404 and perform related validation checks. It must've been working at the time of submission.
https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=412753&view=logs&j=871b4eed-22de-5cb6-c1c8-82f190de633f&t=523ceef4-ddf7-55a0-c83d-dd0f77b67744&l=57

I would agree that even if it was not 404 at the time of submission, this Url should've been caught by now by wingetbot's automatic scan for hash mismatches / faulty Urls. There is work to be done for better handling of such scenarios which is being tracked in #69497

@mdanish-kh
Copy link
Contributor

cc @denelon An example for scenario 3 in #69497 (comment) that should've been caught by wingetbot. For context, the 404 Url is present in the latest version.

@denelon denelon added this to WinGet Jan 18, 2023
@denelon denelon added this to the v.Next-Pipelines milestone Jan 18, 2023
@denelon denelon removed this from WinGet Jun 13, 2023
@denelon denelon removed this from the v.Next-Pipelines milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community.
Projects
None yet
Development

No branches or pull requests

4 participants