Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Updates for GitHub.GitHubDesktop don't distinguish between the stable and beta channels #80610

Open
2 tasks done
Rexogamer opened this issue Sep 23, 2022 · 1 comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@Rexogamer
Copy link
Contributor

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Side-By-Side installation.

Brief description of your issue

GitHub Desktop offers two update channels (stable and beta) - however, winget considers these as one channel. Therefore, beta users are offered updates that would move them to the stable channel. (GitHub Desktop's manifest is also a few versions behind, but I assume this will be resolved at some point.)

(Apologies if this is the wrong issue template - this seemed to me to be the best fit.)

Steps to reproduce

  • Install the beta version of GitHub Desktop here
  • Wait for a newer stable version to release
  • Run winget upgrade

Actual behavior

Stable versions are listed as upgrades, despite the fact that they would move the user out of the beta channel.

Expected behavior

A new version should only be shown if it's a newer beta version, ensuring that users stay in the beta channel. This would be consistent with apps like Discord.

Environment

Windows Package Manager (Preview) v1.4.2161-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.25201.1000
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.2161.0

Screenshots and Logs

No response

@Rexogamer Rexogamer added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 23, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 23, 2022
@Rexogamer Rexogamer changed the title [Package Issue]: Split GitHub.GitHubDesktop into stable/beta channels [Package Issue]: Updates for GitHub.GitHubDesktop don't distinguish between the stable and beta channels Sep 23, 2022
@OfficialEsco
Copy link
Contributor

Ahh i see the issue, i don't think we can fix this as of now since this is not a software that can be installed Side-By-Side.
They both identify as

PackageName: GitHub Desktop
Publisher: Github, Inc.
ProductCode: GitHubDesktop

The only difference is the DisplayVersion which contains -beta at the end.

This can only be resolved by Channels in the future.

@denelon denelon removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants